carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #896: [CARBONDATA-936] Create table with partition a...
Date Thu, 11 May 2017 01:27:52 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/896#discussion_r115889135
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
---
    @@ -381,6 +422,40 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
         return wrapperColumnSchema;
       }
     
    +  private PartitionType fromExternalToWrapperPartitionType(
    +      org.apache.carbondata.format.PartitionType externalPartitionType) {
    +    if (null == externalPartitionType) {
    +      return null;
    +    }
    +    switch (externalPartitionType) {
    +      case HASH:
    +        return PartitionType.HASH;
    +      case LIST:
    +        return PartitionType.LIST;
    +      case RANGE:
    +        return PartitionType.RANGE;
    +      case RANGE_INTERVAL:
    +        return PartitionType.RANGE_INTERVAL;
    +      default:
    +        return PartitionType.HASH;
    +    }
    +  }
    +
    +  private PartitionInfo fromExternalToWrapperPartitionInfo(
    +      org.apache.carbondata.format.PartitionInfo externalPartitionInfo) {
    +    List<ColumnSchema> wrapperColumnSchema = new ArrayList<ColumnSchema>();
    +    for (org.apache.carbondata.format.ColumnSchema columnSchema : externalPartitionInfo
    --- End diff --
    
    move `externalPartitionInfo` to next line, please also check other newly added code in
this class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message