carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #882: [CARBONDATA-936] Parse partition tab...
Date Mon, 08 May 2017 08:24:20 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/882#discussion_r115196558
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
    @@ -24,40 +24,29 @@
     import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema;
     
     /**
    - * Partition Information of carbon partition table
    + * Partition information of carbon partition table
      */
     public class PartitionInfo implements Serializable {
     
    -  /**
    -   * Partition columns
    -   */
       private List<ColumnSchema> columnSchemaList;
     
    -  /**
    -   * partition type
    -   */
       private PartitionType partitionType;
     
       /**
    -   * Range Partition definition
    +   * range infomation defined for range partition table
        */
       private List<String> rangeInfo;
     
       /**
    -   * List Partition definition
    +   * value list defined for list partition table
        */
       private List<List<String>> listInfo;
     
       /**
    -   * Hash Partition numbers
    +   * hash partition numbers
    --- End diff --
    
    This should be number of partition. 
    The variable name suggest to change to `numPartitions`, which is aligned with spark


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message