carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #876: [CARBONDATA-935] Define PartitionInf...
Date Wed, 03 May 2017 06:57:54 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/876#discussion_r114481333
  
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -121,6 +127,24 @@ struct SchemaEvolution{
     }
     
     /**
    + * One partition in table
    + */
    +struct Partition{
    +    1: optional i32 partition_id;
    +    2: required list<string> boundary_value_list;
    +}
    +
    +/**
    + * Partition information of table
    + */
    +struct PartitionInfo{
    --- End diff --
    
    To make this metadata more clear, can we do like this:
    `struct PartitionInfo {
    1: required PartitionType type;
    2: optional RangePartitionInfo rangePartitionInfo;
    3: optional ListPartitionInfo listPartitionInfo;
    ...
    }
    `
    So that you can access each partition info based on the first member (type)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message