carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhavya411 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #816: [CARBONDATA-944] Fixed unwanted exce...
Date Tue, 02 May 2017 10:23:58 GMT
Github user bhavya411 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/816#discussion_r114288845
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -112,7 +112,17 @@ class CarbonSource extends CreatableRelationProvider with RelationProvider
           dataSchema: StructType): BaseRelation = {
         CarbonEnv.getInstance(sqlContext.sparkSession)
         addLateDecodeOptimization(sqlContext.sparkSession)
    -    val path = createTableIfNotExists(sqlContext.sparkSession, parameters, dataSchema)
    +    val dbName: String = parameters.getOrElse("dbName",
    +      CarbonCommonConstants.DATABASE_DEFAULT_NAME).toLowerCase
    +    val tableName: String = parameters.getOrElse("tableName", "default_table").toLowerCase
    --- End diff --
    
    @jackylk  I can not call it in the caller function as the createRelation method is a framework
metthod so it can be called while Using clause is used , if I move the code to caller function
the createTableIfnotExists will not be called in that scenario. Please let me know if we still
need to do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message