Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-849-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-849-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #849: [CARBONDATA-992] Fix error of Exampl...
Content-Type: text/plain
Message-Id: <20170427202610.A1AFCDFDAC@git1-us-west.apache.org>
Date: Thu, 27 Apr 2017 20:26:10 +0000 (UTC)
archived-at: Thu, 27 Apr 2017 20:26:15 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/849#discussion_r113793937
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDatasourceHadoopRelation.scala ---
    @@ -75,4 +75,16 @@ case class CarbonDatasourceHadoopRelation(
         ", " + "Table name :" + carbonTable.getFactTableName + ", Schema :" + tableSchema + " ]"
       }
     
    +  override def insert(data: DataFrame, overwrite: Boolean): Unit = {
    +    if (carbonRelation.output.size > CarbonCommonConstants.DEFAULT_MAX_NUMBER_OF_COLUMNS) {
    +      sys.error("Maximum supported column by carbon is: " +
    +          CarbonCommonConstants.DEFAULT_MAX_NUMBER_OF_COLUMNS)
    +    }
    +    if(data.logicalPlan.output.size >= carbonRelation.output.size) {
    --- End diff --
    
    what if the size equals but schema is different?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---