Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: nareshpr <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-790-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-790-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #790: [CARBONDATA-919]result_size in query...
Content-Type: text/plain
Message-Id: <20170413101643.DAEA5DFC31@git1-us-west.apache.org>
Date: Thu, 13 Apr 2017 10:16:43 +0000 (UTC)
archived-at: Thu, 13 Apr 2017 10:16:49 -0000

Github user nareshpr commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/790#discussion_r111356217
  
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java ---
    @@ -147,7 +148,11 @@ public VectorizedCarbonRecordReader(QueryModel queryModel) {
       }
     
       @Override public Object getCurrentValue() throws IOException, InterruptedException {
    -    if (returnColumnarBatch) return columnarBatch;
    +    if (returnColumnarBatch) {
    +      rowCount += columnarBatch.numValidRows();
    +      return columnarBatch;
    +    }
    +    rowCount += 1;
    --- End diff --
    
    if incase returnColumnarBatch is false, we are return only 1 row.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---