Return-Path: <issues-return-7619-archive-asf-public=cust-asf.ponee.io@carbondata.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 148CE200C48
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  6 Apr 2017 11:38:41 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 1324C160B84; Thu,  6 Apr 2017 09:38:41 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 5B44B160B83
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  6 Apr 2017 11:38:40 +0200 (CEST)
Received: (qmail 40841 invoked by uid 500); 6 Apr 2017 09:38:39 -0000
Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.incubator.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.incubator.apache.org>
List-Post: <mailto:issues@carbondata.incubator.apache.org>
List-Id: <issues.carbondata.incubator.apache.org>
Reply-To: dev@carbondata.incubator.apache.org
Delivered-To: mailing list issues@carbondata.incubator.apache.org
Received: (qmail 40832 invoked by uid 99); 6 Apr 2017 09:38:38 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Apr 2017 09:38:38 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 740CE18055C
	for <issues@carbondata.apache.org>; Thu,  6 Apr 2017 09:38:38 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id 1l1yendSdMKx for <issues@carbondata.apache.org>;
	Thu,  6 Apr 2017 09:38:36 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 4B0EF5F2FE
	for <issues@carbondata.incubator.apache.org>; Thu,  6 Apr 2017 09:38:35 +0000 (UTC)
Received: (qmail 40822 invoked by uid 99); 6 Apr 2017 09:38:34 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Apr 2017 09:38:34 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 6AAA4DFF73; Thu,  6 Apr 2017 09:38:34 +0000 (UTC)
From: chenliang613 <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-738-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-738-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...
Content-Type: text/plain
Message-Id: <20170406093834.6AAA4DFF73@git1-us-west.apache.org>
Date: Thu,  6 Apr 2017 09:38:34 +0000 (UTC)
archived-at: Thu, 06 Apr 2017 09:38:41 -0000

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/738#discussion_r110118360
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataSplitManager.java ---
    @@ -249,6 +250,11 @@ public Expression parseFilterExpression(TupleDomain<ColumnHandle> originalConstr
         return finalFilters;
       }
     
    +  /**
    +   * Convert presto spi Type into Carbondata Type
    +   * @param colType
    +   * @return
    +     */
    --- End diff --
    
    please change the comment format


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---