Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-722-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-722-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...
Content-Type: text/plain
Message-Id: <20170405013753.6ABBADFE34@git1-us-west.apache.org>
Date: Wed,  5 Apr 2017 01:37:53 +0000 (UTC)
archived-at: Wed, 05 Apr 2017 01:37:57 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815295
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala ---
    @@ -154,6 +154,79 @@ class TestSortColumns extends QueryTest with BeforeAndAfterAll {
         checkAnswer(sql("select * from sorttable6 where empname = 'madhan'"), sql("select * from origintable1 where empname = 'madhan'"))
       }
     
    +  test("no sort_columns with and data loading with heap and safe sort config") {
    +    try {
    +      setLoadingProperties("false", "false", "false")
    +      sql("CREATE TABLE sorttable7_heap_safe (empno int, empname String, designation String, doj Timestamp, workgroupcategory int, workgroupcategoryname String, deptno int, deptname String, projectcode int, projectjoindate Timestamp, projectenddate Timestamp,attendance int,utilization int,salary int) STORED BY 'org.apache.carbondata.format' tblproperties('sort_columns'='')")
    +      sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE sorttable7_heap_safe OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
    +      checkAnswer(sql("select * from sorttable7_heap_safe where empno = 11"), sql("select * from origintable1 where empno = 11"))
    +      checkAnswer(sql("select * from sorttable7_heap_safe order by empno"), sql("select * from origintable1 order by empno"))
    +    } finally {
    +      defaultLoadingProperties
    +    }
    +  }
    +
    +  test("no sort_columns with and data loading with heap and unsafe sort config") {
    --- End diff --
    
    please change the test title for all newly added testcase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---