carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #816: [CARBONDATA-944] Fixed unwanted exce...
Date Fri, 28 Apr 2017 05:12:47 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/816#discussion_r113853461
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
    @@ -112,7 +112,17 @@ class CarbonSource extends CreatableRelationProvider with RelationProvider
           dataSchema: StructType): BaseRelation = {
         CarbonEnv.getInstance(sqlContext.sparkSession)
         addLateDecodeOptimization(sqlContext.sparkSession)
    -    val path = createTableIfNotExists(sqlContext.sparkSession, parameters, dataSchema)
    +    val dbName: String = parameters.getOrElse("dbName",
    +      CarbonCommonConstants.DATABASE_DEFAULT_NAME).toLowerCase
    +    val tableName: String = parameters.getOrElse("tableName", "default_table").toLowerCase
    --- End diff --
    
    can you do this check in caller function where you can use CarbonOption to get the dbName
and tableName instead of doing it here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message