carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #833: [CARBONDATA-951] create table ddl ca...
Date Tue, 25 Apr 2017 01:59:15 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/833#discussion_r113093434
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -385,6 +391,13 @@ class TableNewProcessor(cm: TableModel) {
             field.scale,
             field.schemaOrdinal)
           columnSchema.setSortColumn(true)
    +      if (bitmapCols.contains(field.column)) {
    +        if (columnSchema.getEncodingList.contains(Encoding.DICTIONARY)) {
    --- End diff --
    
    why not add these code into getColumnSchema method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message