carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #843: [CARBONDATA-978] Range Filter Evalua...
Date Mon, 24 Apr 2017 11:12:14 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/843#discussion_r112919687
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
    @@ -431,14 +426,9 @@ private BitSet setFilterdIndexToBitSetWithColumnIndex(
             if (start == numerOfRows) {
               start = start - 1;
             }
    -        // Method will compare the tentative index value after binary search, this tentative
    -        // index needs to be compared by the filter member if its >= filter then from
that
    -        // index the bitset will be considered for filtering process.
    -        if ((lessThanExp == true) && (ByteUtil.compare(filterValues[1],
    -            dimensionColumnDataChunk.getChunkData(dimensionColumnDataChunk.getInvertedIndex(start)))
    -            < 0)) {
    -          start = start - 1;
    -        } else if ((lessThanEqualExp == true) && (ByteUtil.compare(filterValues[1],
    +        // In case the start is less than 0, then positive value of start is pointing
to the next
    +        // value of the searched key. So move to the previous one.
    +        if ((ByteUtil.compare(filterValues[1],
    --- End diff --
    
    Please don't use this compare method, it does not compare based on length


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message