carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #838: [CARBONDATA-974] Improve Carbon inde...
Date Fri, 21 Apr 2017 17:30:16 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/838#discussion_r112738876
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
---
    @@ -274,6 +275,35 @@ public String getCarbonIndexFilePath(final String taskId, final String
partition
               + "]");
         }
       }
    +
    +  /**
    +   * Below method will be used to get the carbon index file path
    +   * @param taskId
    +   *        task id
    +   * @param partitionId
    +   *        partition id
    +   * @param segmentId
    +   *        segment id
    +   * @param bucketNumber
    +   *        bucket number
    +   * @param timeStamp
    +   *        timestamp
    +   * @return carbon index file path
    +   */
    +  public String getCarbonIndexFilePath(String taskId, String partitionId, String segmentId,
    +      String bucketNumber, String timeStamp, ColumnarFormatVersion columnarFormatVersion)
{
    +    if (ColumnarFormatVersion.V3 != columnarFormatVersion) {
    --- End diff --
    
    Better add a switch case and make V3 as default instead of strictly checking with V3 format.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message