carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #802: [CARBONDATA-926] Changed max columns...
Date Sat, 15 Apr 2017 14:45:44 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/802#discussion_r111665089
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvload/CSVInputFormat.java
---
    @@ -220,8 +241,16 @@ private CsvParserSettings extractCsvParserSettings(Configuration
job) {
           parserSettings.setIgnoreTrailingWhitespaces(false);
           parserSettings.setSkipEmptyLines(false);
           parserSettings.setMaxCharsPerColumn(100000);
    -      // TODO get from csv file.
    -      parserSettings.setMaxColumns(1000);
    +      String maxColumns = job.get(MAX_COLUMNS);
    +      int maxColumnsInt = 0;
    --- End diff --
    
    default value should be taken and same should be logged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message