carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #802: [CARBONDATA-926] Changed max columns...
Date Sat, 15 Apr 2017 14:45:44 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/802#discussion_r111665083
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/csvload/CSVInputFormat.java
---
    @@ -231,6 +260,31 @@ private CsvParserSettings extractCsvParserSettings(Configuration
job) {
           return parserSettings;
         }
     
    +    /**
    +     * This method will decide the number of columns to be parsed for a row by Csv parser
    +     *
    +     * @param columnCountInSchema total number of columns in schema
    +     * @return
    +     */
    +    private int getMaxColumnsForParsing(int columnCountInSchema, int maxColumns) {
    +      int maxNumberOfColumnsForParsing = DEFAULT_MAX_NUMBER_OF_COLUMNS_FOR_PARSING;
    +      if (maxColumns > 0) {
    +        if (columnCountInSchema >= maxColumns) {
    +          maxNumberOfColumnsForParsing = columnCountInSchema + 1;
    --- End diff --
    
    taking more columns than the configured max value, should not happen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message