carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #769: [CARBONDATA-888] Added include and e...
Date Tue, 11 Apr 2017 01:28:33 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/769#discussion_r110798836
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonDataFrameWriter.scala
---
    @@ -175,13 +175,17 @@ class CarbonDataFrameWriter(val dataFrame: DataFrame) {
       }
     
       private def makeCreateTableString(schema: StructType, options: CarbonOption): String
= {
    +    val properties = Map("DICTIONARY_INCLUDE" -> options.dictionaryInclude,
    +      "DICTIONARY_EXCLUDE" -> options.dictionaryExclude).filter(_._2.isDefined)
    +      .map(p => s"'${p._1}' = '${p._2.get}'").mkString(",")
    --- End diff --
    
    please format it as in spark2 below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message