carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #656: [CARBONDATA-773] Fixed multiple Dict...
Date Mon, 10 Apr 2017 12:03:52 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/656#discussion_r106594167
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
    @@ -963,15 +962,14 @@ object CarbonDataRDDFactory {
                           .getTableName
                     }")
                 LOGGER.error("Dataload failed due to failure in table status updation.")
    -            shutDownDictionaryServer(carbonLoadModel, result, false)
                 throw new Exception(errorMessage)
               }
             } else if (!carbonLoadModel.isRetentionRequest) {
               // TODO : Handle it
               LOGGER.info("********Database updated**********")
             }
     
    -        shutDownDictionaryServer(carbonLoadModel, result)
    +        writeDictionary(carbonLoadModel, result)
    --- End diff --
    
    Write dictionary should happen before metadata update, if any failure in writedictionary
should fail data load.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message