carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #767: fix sort_columns issue(12-dev)
Date Sun, 09 Apr 2017 02:22:45 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/767#discussion_r110531208
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/resolver/RowLevelRangeFilterResolverImpl.java
---
    @@ -147,12 +148,16 @@ public void getStartKey(SegmentProperties segmentProperties, long[]
startKey,
               filterValuesList.add(CarbonCommonConstants.MEMBER_DEFAULT_VAL.getBytes());
               continue;
             }
    -        filterValuesList.add(result.getString().getBytes());
    +        filterValuesList.add(DataTypeUtil
    +            .getBytesBasedOnDataTypeForNoDictionaryColumn(result.getString(),
    +                result.getDataType()));
           } catch (FilterIllegalMemberException e) {
             // Any invalid member while evaluation shall be ignored, system will log the
             // error only once since all rows the evaluation happens so inorder to avoid
             // too much log inforation only once the log will be printed.
             FilterUtil.logError(e, invalidRowsPresent);
    +      } catch (Throwable throwable) {
    --- End diff --
    
    why is this added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message