carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #727: [CARBONDATA-846] Added support to re...
Date Thu, 06 Apr 2017 08:48:57 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/727#discussion_r110108435
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala
---
    @@ -89,9 +89,8 @@ private[sql] case class AlterTableAddColumns(
           LOGGER.info(s"Alter table for add columns is successful for table $dbName.$tableName")
           LOGGER.audit(s"Alter table for add columns is successful for table $dbName.$tableName")
         } catch {
    -      case e: Exception =>
    -        LOGGER.error(e, s"Alter table add columns failed : ${e.getMessage}")
    -        // clean up the dictionary files in case of any failure
    +      case runTimeException: RuntimeException => LOGGER
    --- End diff --
    
    why catch only `RuntimeException` ? why not `Exception` or any specific exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message