carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #703: [CARBONDATA-780] Alter table support...
Date Thu, 06 Apr 2017 08:47:41 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/703#discussion_r110108215
  
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/merger/CarbonCompactionUtil.java
---
    @@ -351,4 +351,33 @@ private static int getDimensionDefaultCardinality(CarbonDimension
dimension) {
         }
         return cardinality;
       }
    +
    +  /**
    +   * This method will check for any restructured block in the blocks selected for compaction
    +   *
    +   * @param segmentMapping
    +   * @param dataFileMetadataSegMapping
    +   * @param tableLastUpdatedTime
    +   * @return
    +   */
    +  public static boolean checkIfAnyRestructuredBlockExists(Map<String, TaskBlockInfo>
segmentMapping,
    +      Map<String, List<DataFileFooter>> dataFileMetadataSegMapping, long
tableLastUpdatedTime) {
    +    boolean restructuredBlockExists = false;
    +    for (Map.Entry<String, TaskBlockInfo> taskMap : segmentMapping.entrySet())
{
    +      String segmentId = taskMap.getKey();
    +      List<DataFileFooter> listMetadata = dataFileMetadataSegMapping.get(segmentId);
    +      for (DataFileFooter dataFileFooter : listMetadata) {
    +        // if schema modified timestamp is greater than footer stored schema timestamp,
    --- End diff --
    
    yes...because the entry will be added in schema evolution entry and in case of any failure
we need to revert back the schema


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message