carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...
Date Wed, 05 Apr 2017 01:39:26 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815428
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
    @@ -490,8 +490,20 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser
{
         // All columns in sortkey should be there in create table cols
         val sortKeyOption = tableProperties.get(CarbonCommonConstants.SORT_COLUMNS)
         var sortKeyDimsTmp: Seq[String] = Seq[String]()
    -    if (sortKeyOption.isDefined) {
    -      var sortKey = sortKeyOption.get.split(',').map(_.trim)
    +    val sortKeyString: String = if (sortKeyOption.isDefined) {
    --- End diff --
    
    can you extract this logic (getting value from ' ' or " "), is other options doing the
same? maybe it can be shared


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message