carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...
Date Wed, 05 Apr 2017 01:35:25 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815081
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
---
    @@ -54,6 +54,8 @@
        */
       private KeyGenerator dimensionKeyGenerator;
     
    +  private KeyGenerator sortColumnsGenerator;
    --- End diff --
    
    please add comment for this member variable and `dimensionKeyGenerator`, to describe their
difference


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message