Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5A239200C51 for ; Sun, 26 Mar 2017 07:57:34 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4E4E5160B96; Sun, 26 Mar 2017 05:57:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 95A78160B88 for ; Sun, 26 Mar 2017 07:57:33 +0200 (CEST) Received: (qmail 91856 invoked by uid 500); 26 Mar 2017 05:57:32 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 91844 invoked by uid 99); 26 Mar 2017 05:57:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Mar 2017 05:57:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4FC5DC0370 for ; Sun, 26 Mar 2017 05:57:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FGmHvHBPvDge for ; Sun, 26 Mar 2017 05:57:31 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 3BA135F30C for ; Sun, 26 Mar 2017 05:57:30 +0000 (UTC) Received: (qmail 91839 invoked by uid 99); 26 Mar 2017 05:57:29 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Mar 2017 05:57:29 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 19AC5E04F0; Sun, 26 Mar 2017 05:57:29 +0000 (UTC) From: chenliang613 To: issues@carbondata.incubator.apache.org Reply-To: issues@carbondata.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-carbondata pull request #696: [CARBONDATA-818] Make the file_name ... Content-Type: text/plain Message-Id: <20170326055729.19AC5E04F0@git1-us-west.apache.org> Date: Sun, 26 Mar 2017 05:57:29 +0000 (UTC) archived-at: Sun, 26 Mar 2017 05:57:34 -0000 Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052521 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/v1/CarbonFactDataWriterImplV1.java --- @@ -373,7 +373,7 @@ protected void writeBlockletInfoToFile(FileChannel channel, String filePath) FileFooter convertFileMeta = CarbonMetadataUtil .convertFileFooter(blockletInfoList, localCardinality.length, localCardinality, thriftColumnSchemaList, dataWriterVo.getSegmentProperties()); - fillBlockIndexInfoDetails(convertFileMeta.getNum_rows(), filePath, currentPosition); + fillBlockIndexInfoDetails(convertFileMeta.getNum_rows(), carbonDataFileName, currentPosition); --- End diff -- Please align the parameter name(filePath) for fillBlockIndexInfoDetails of AbstractFactDataWriter.java For example : protected void fillBlockIndexInfoDetails(long numberOfRows, String carbonDataFileName, long currentPosition) Please modify accordingly for all part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---