Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: QiangCai <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-672-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-672-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...
Content-Type: text/plain
Message-Id: <20170324124925.1A588DFC15@git1-us-west.apache.org>
Date: Fri, 24 Mar 2017 12:49:25 +0000 (UTC)
archived-at: Fri, 24 Mar 2017 12:49:30 -0000

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863484
  
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java ---
    @@ -0,0 +1,191 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.hive;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
    +import org.apache.hadoop.hive.serde2.objectinspector.SettableListObjectInspector;
    +import org.apache.hadoop.io.ArrayWritable;
    +import org.apache.hadoop.io.Writable;
    +
    +/**
    + * The CarbonHiveArrayInspector will inspect an ArrayWritable, considering it as an Hive array.
    + * It can also inspect a List if Hive decides to inspect the result of an inspection.
    + */
    +public class CarbonArrayInspector implements SettableListObjectInspector {
    +
    +  ObjectInspector arrayElementInspector;
    +
    +  public CarbonArrayInspector(final ObjectInspector arrayElementInspector) {
    +    this.arrayElementInspector = arrayElementInspector;
    +  }
    +
    +  @Override
    +  public String getTypeName() {
    +    return "array<" + arrayElementInspector.getTypeName() + ">";
    +  }
    +
    +  @Override
    +  public Category getCategory() {
    +    return Category.LIST;
    +  }
    +
    +  @Override
    +  public ObjectInspector getListElementObjectInspector() {
    +    return arrayElementInspector;
    +  }
    +
    +  @Override
    +  public Object getListElement(final Object data, final int index) {
    +    if (data == null) {
    +      return null;
    +    }
    +
    +    if (data instanceof ArrayWritable) {
    +      final Writable[] listContainer = ((ArrayWritable) data).get();
    +
    +      if (listContainer == null || listContainer.length == 0) {
    +        return null;
    +      }
    +
    +      final Writable subObj = listContainer[0];
    +
    +      if (subObj == null) {
    +        return null;
    +      }
    +
    +      if (index >= 0 && index < ((ArrayWritable) subObj).get().length) {
    +        return ((ArrayWritable) subObj).get()[index];
    +      } else {
    +        return null;
    +      }
    +    }
    +
    +    throw new UnsupportedOperationException("Cannot inspect "
    +      + data.getClass().getCanonicalName());
    +  }
    +
    +  @Override
    +  public int getListLength(final Object data) {
    +    if (data == null) {
    +      return -1;
    +    }
    +
    +    if (data instanceof ArrayWritable) {
    +      final Writable[] listContainer = ((ArrayWritable) data).get();
    +
    +      if (listContainer == null || listContainer.length == 0) {
    +        return -1;
    +      }
    +
    +      final Writable subObj = listContainer[0];
    +
    +      if (subObj == null) {
    +        return 0;
    +      }
    +
    +      return ((ArrayWritable) subObj).get().length;
    +    }
    +
    +    throw new UnsupportedOperationException("Cannot inspect "
    +      + data.getClass().getCanonicalName());
    +  }
    +
    +  @Override
    +  public List<?> getList(final Object data) {
    +    if (data == null) {
    +      return null;
    +    }
    +
    +    if (data instanceof ArrayWritable) {
    +      final Writable[] listContainer = ((ArrayWritable) data).get();
    +
    +      if (listContainer == null || listContainer.length == 0) {
    +        return null;
    +      }
    +
    +      final Writable subObj = listContainer[0];
    +
    +      if (subObj == null) {
    +        return null;
    +      }
    +
    +      final Writable[] array = ((ArrayWritable) subObj).get();
    +      final List<Writable> list = new ArrayList<Writable>();
    +
    +      for (final Writable obj : array) {
    +        list.add(obj);
    +      }
    +
    +      return list;
    +    }
    +
    +    throw new UnsupportedOperationException("Cannot inspect "
    +      + data.getClass().getCanonicalName());
    +  }
    +
    +  @Override
    +  public Object create(final int size) {
    +    final ArrayList<Object> result = new ArrayList<Object>(size);
    +    for (int i = 0; i < size; ++i) {
    +      result.add(null);
    +    }
    +    return result;
    +  }
    +
    +  @Override
    +  public Object set(final Object list, final int index, final Object element) {
    +    final ArrayList l = (ArrayList) list;
    --- End diff --
    
    unchecked type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---