Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-678-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-678-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #678: [CARBONDATA-798] Added support to re...
Content-Type: text/plain
Message-Id: <20170322051623.AF51DDFE1D@git1-us-west.apache.org>
Date: Wed, 22 Mar 2017 05:16:23 +0000 (UTC)
archived-at: Wed, 22 Mar 2017 05:23:21 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/678#discussion_r107334090
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala ---
    @@ -198,6 +200,27 @@ private[sql] case class AlterTableRenameTable(alterTableRenameModel: AlterTableR
         }
         Seq.empty
       }
    +
    +  private def renameBadRecords(oldTableName: String,
    +      newTableName: String,
    +      dataBaseName: String) = {
    +    val badRecordsLocation = CarbonProperties.getInstance()
    +      .getProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC,
    +        CarbonCommonConstants.CARBON_BADRECORDS_LOC_DEFAULT_VAL)
    +    val badRecordsDatabase = badRecordsLocation + CarbonCommonConstants.FILE_SEPARATOR +
    --- End diff --
    
    Use a common function to get bad records location


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---