Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: sounakr <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-670-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-670-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...
Content-Type: text/plain
Message-Id: <20170321054122.9606ADFE8F@git1-us-west.apache.org>
Date: Tue, 21 Mar 2017 05:41:22 +0000 (UTC)
archived-at: Tue, 21 Mar 2017 05:41:28 -0000

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/670#discussion_r107077246
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java ---
    @@ -0,0 +1,557 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.scan.filter.executer;
    +
    +import java.io.IOException;
    +import java.util.BitSet;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.datastore.chunk.DimensionColumnDataChunk;
    +import org.apache.carbondata.core.datastore.chunk.impl.DimensionRawColumnChunk;
    +import org.apache.carbondata.core.datastore.chunk.impl.FixedLengthDimensionDataChunk;
    +import org.apache.carbondata.core.datastore.chunk.impl.VariableLengthDimensionDataChunk;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
    +import org.apache.carbondata.core.metadata.schema.table.column.CarbonDimension;
    +import org.apache.carbondata.core.scan.expression.Expression;
    +import org.apache.carbondata.core.scan.expression.conditional.GreaterThanEqualToExpression;
    +import org.apache.carbondata.core.scan.expression.conditional.GreaterThanExpression;
    +import org.apache.carbondata.core.scan.expression.conditional.LessThanEqualToExpression;
    +import org.apache.carbondata.core.scan.expression.conditional.LessThanExpression;
    +import org.apache.carbondata.core.scan.expression.exception.FilterUnsupportedException;
    +import org.apache.carbondata.core.scan.filter.FilterUtil;
    +import org.apache.carbondata.core.scan.filter.resolver.resolverinfo.DimColumnResolvedFilterInfo;
    +import org.apache.carbondata.core.scan.filter.resolver.resolverinfo.MeasureColumnResolvedFilterInfo;
    +import org.apache.carbondata.core.scan.processor.BlocksChunkHolder;
    +import org.apache.carbondata.core.util.BitSetGroup;
    +import org.apache.carbondata.core.util.ByteUtil;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +
    +public class RangeValueFilterExecuterImpl extends ValueBasedFilterExecuterImpl {
    +
    +  private DimColumnResolvedFilterInfo dimColEvaluatorInfo;
    +  private MeasureColumnResolvedFilterInfo msrColEvalutorInfo;
    +  private AbsoluteTableIdentifier tableIdentifier;
    +  private Expression exp;
    +  private byte[][] filterRangesValues;
    +  private SegmentProperties segmentProperties;
    +  private boolean isDefaultValuePresentInFilter;
    +  /**
    +   * it has index at which given dimension is stored in file
    +   */
    +  protected int dimensionBlocksIndex;
    +
    +  /**
    +   * flag to check whether the filter dimension is present in current block list of dimensions.
    +   * Applicable for restructure scenarios
    +   */
    +  protected boolean isDimensionPresentInCurrentBlock;
    +
    +  public RangeValueFilterExecuterImpl(DimColumnResolvedFilterInfo dimColEvaluatorInfo,
    +      MeasureColumnResolvedFilterInfo msrColEvaluatorInfo, Expression exp,
    +      AbsoluteTableIdentifier tableIdentifier, byte[][] filterRangeValues,
    +      SegmentProperties segmentProperties) {
    +
    +    this.dimColEvaluatorInfo = dimColEvaluatorInfo;
    +    this.msrColEvalutorInfo = msrColEvaluatorInfo;
    +    this.exp = exp;
    +    this.segmentProperties = segmentProperties;
    +    this.tableIdentifier = tableIdentifier;
    +    this.filterRangesValues = filterRangeValues;
    +    initDimensionBlockIndexes();
    +    ifDefaultValueMatchesFilter();
    +  }
    +
    +  /**
    +   * This method will initialize the dimension info for the current block to be
    +   * used for filtering the data
    +   */
    +  private void initDimensionBlockIndexes() {
    +    // find the dimension in the current block dimensions list
    +    CarbonDimension dimensionFromCurrentBlock =
    +        segmentProperties.getDimensionFromCurrentBlock(dimColEvaluatorInfo.getDimension());
    +    if (null != dimensionFromCurrentBlock) {
    +      dimColEvaluatorInfo.setColumnIndex(dimensionFromCurrentBlock.getOrdinal());
    +      this.dimensionBlocksIndex = segmentProperties.getDimensionOrdinalToBlockMapping()
    +          .get(dimensionFromCurrentBlock.getOrdinal());
    +      isDimensionPresentInCurrentBlock = true;
    +    }
    +  }
    +
    +  /**
    +   * This method will check whether default value is present in the given filter values
    +   */
    +  private void ifDefaultValueMatchesFilter() {
    +    isDefaultValuePresentInFilter = false;
    +    if (this.isDimensionPresentInCurrentBlock) {
    +      CarbonDimension dimension = this.dimColEvaluatorInfo.getDimension();
    +      byte[] defaultValue = dimension.getDefaultValue();
    +      if (null != defaultValue) {
    +        int maxCompare =
    +            ByteUtil.UnsafeComparer.INSTANCE.compareTo(defaultValue, filterRangesValues[0]);
    +        int minCompare =
    +            ByteUtil.UnsafeComparer.INSTANCE.compareTo(filterRangesValues[1], defaultValue);
    +
    +        if (((isGreaterThan() && maxCompare > 0) || (isGreaterThanEqualTo() && maxCompare >= 0))
    +            && ((isLessThan() && minCompare > 0) || (isLessThanEqualTo() && minCompare >= 0))) {
    +          isDefaultValuePresentInFilter = true;
    +        }
    +      }
    +    }
    +  }
    +
    +  /**
    +   * Method to apply the filter.
    +   * @param blockChunkHolder
    +   * @return
    +   * @throws FilterUnsupportedException
    +   * @throws IOException
    +   */
    +  public BitSetGroup applyFilter(BlocksChunkHolder blockChunkHolder)
    +      throws FilterUnsupportedException, IOException {
    +    return applyNoAndDirectFilter(blockChunkHolder);
    +  }
    +
    +  /**
    +   * Method to find presence of LessThan Expression.
    +   * @return
    +   */
    +  private boolean isLessThan() {
    +    for (Expression result : this.exp.getChildren()) {
    +      if (result instanceof LessThanExpression) {
    +        return true;
    +      }
    +    }
    +    return false;
    +  }
    +
    +  /**
    +   * Method to find presence of LessThanEqualTo Expression.
    +   * @return
    +   */
    +  private boolean isLessThanEqualTo() {
    +    for (Expression result : this.exp.getChildren()) {
    +      if (result instanceof LessThanEqualToExpression) {
    +        return true;
    +      }
    +    }
    +    return false;
    +  }
    +
    +  /**
    +   * Method to find presence of GreaterThan Expression.
    +   * @return
    +   */
    +  private boolean isGreaterThan() {
    +    for (Expression result : this.exp.getChildren()) {
    +      if (result instanceof GreaterThanExpression) {
    +        return true;
    +      }
    +    }
    +    return false;
    +  }
    +
    +  /**
    +   * Method to find presence of GreaterThanEqual Expression.
    +   * @return
    +   */
    +  private boolean isGreaterThanEqualTo() {
    +    for (Expression result : this.exp.getChildren()) {
    +      if (result instanceof GreaterThanEqualToExpression) {
    +        return true;
    +      }
    +    }
    +    return false;
    +  }
    +
    +  /**
    +   * Method to identify if scanning of Data Block required or not by comparing the Block Min and Max
    +   * values and comparing them with filter min and max value.
    +   * @param blockMinValue
    +   * @param blockMaxValue
    +   * @param filterValues
    +   * @return
    +   */
    +  public boolean isScanRequired(byte[] blockMinValue, byte[] blockMaxValue, byte[][] filterValues) {
    +    boolean isScanRequired = true;
    +
    +    boolean lessThan = isLessThan();
    +    boolean greaterThan = isGreaterThan();
    +    boolean greaterThanEqualTo = isGreaterThanEqualTo();
    +    boolean lessThanEqualTo = isLessThanEqualTo();
    +
    +    int filterMinlessThanBlockMin =
    +        ByteUtil.UnsafeComparer.INSTANCE.compareTo(blockMinValue, filterValues[0]);
    +    int filterMaxLessThanBlockMin =
    +        ByteUtil.UnsafeComparer.INSTANCE.compareTo(blockMinValue, filterValues[1]);
    +
    +    int filterMinGreaterThanBlockMax =
    --- End diff --
    
    Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---