Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-673-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-673-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #673: [CARBONDATA-794] Numeric dimension c...
Content-Type: text/plain
Message-Id: <20170320121817.D95EFDFE34@git1-us-west.apache.org>
Date: Mon, 20 Mar 2017 12:18:17 +0000 (UTC)
archived-at: Mon, 20 Mar 2017 12:18:32 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/673#discussion_r106886493
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/DictionaryFieldConverterImpl.java ---
    @@ -94,8 +97,19 @@ public DictionaryFieldConverterImpl(DataField dataField,
       @Override public void convert(CarbonRow row, BadRecordLogHolder logHolder)
           throws CarbonDataLoadingException {
         try {
    -      String parsedValue = DataTypeUtil.parseValue(row.getString(index), carbonDimension);
    -      if (null == parsedValue || parsedValue.equals(nullFormat)) {
    +      String dimensionValue = row.getString(index);
    +      if (dimensionValue == null || dimensionValue.equals(nullFormat)) {
    --- End diff --
    
    write comment that this is alter case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---