Return-Path: <issues-return-6424-archive-asf-public=cust-asf.ponee.io@carbondata.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 48CCB200C3D
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 14 Mar 2017 18:31:10 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 47912160B89; Tue, 14 Mar 2017 17:31:10 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 989A9160B7E
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 14 Mar 2017 18:31:09 +0100 (CET)
Received: (qmail 76397 invoked by uid 500); 14 Mar 2017 17:31:07 -0000
Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.incubator.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.incubator.apache.org>
List-Post: <mailto:issues@carbondata.incubator.apache.org>
List-Id: <issues.carbondata.incubator.apache.org>
Reply-To: dev@carbondata.incubator.apache.org
Delivered-To: mailing list issues@carbondata.incubator.apache.org
Received: (qmail 76388 invoked by uid 99); 14 Mar 2017 17:31:07 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2017 17:31:07 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 33934C7E27
	for <issues@carbondata.apache.org>; Tue, 14 Mar 2017 17:31:07 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.02
X-Spam-Level: 
X-Spam-Status: No, score=-4.02 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id jC4KwCnRIcLN for <issues@carbondata.apache.org>;
	Tue, 14 Mar 2017 17:31:06 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id AE9915F2EF
	for <issues@carbondata.incubator.apache.org>; Tue, 14 Mar 2017 17:31:05 +0000 (UTC)
Received: (qmail 76215 invoked by uid 99); 14 Mar 2017 17:31:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2017 17:31:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 891EEDFE34; Tue, 14 Mar 2017 17:31:04 +0000 (UTC)
From: gvramana <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-641-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-641-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #641: [CARBONDATA-767] Alter table support...
Content-Type: text/plain
Message-Id: <20170314173104.891EEDFE34@git1-us-west.apache.org>
Date: Tue, 14 Mar 2017 17:31:04 +0000 (UTC)
archived-at: Tue, 14 Mar 2017 17:31:10 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/641#discussion_r105962095
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/resolver/resolverinfo/visitor/NoDictionaryTypeVisitor.java ---
    @@ -45,7 +47,15 @@ public void populateFilterResolvedInfo(DimColumnResolvedFilterInfo visitableObj,
         DimColumnFilterInfo resolvedFilterObject = null;
         List<String> evaluateResultListFinal;
         try {
    -      evaluateResultListFinal = metadata.getExpression().evaluate(null).getListAsString();
    +      ExpressionResult result = metadata.getExpression().evaluate(null);
    --- End diff --
    
    if need to check only is null scenario, use expression.isInstanceOf[EqualToExpresson].isNull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---