Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-654-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-654-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #654: [CARBONDATA-770] Fixed Not null filt...
Content-Type: text/plain
Message-Id: <20170314171103.B89F7DFC15@git1-us-west.apache.org>
Date: Tue, 14 Mar 2017 17:11:03 +0000 (UTC)
archived-at: Tue, 14 Mar 2017 17:11:24 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/654#discussion_r105970182
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -507,12 +507,25 @@ public static String parseValue(String value, CarbonDimension dimension) {
           switch (dimension.getDataType()) {
             case DECIMAL:
               return parseStringToBigDecimal(value, dimension);
    +        case INT:
    +          Integer.parseInt(value);
    +          break;
    +        case DOUBLE:
    +          Double.parseDouble(value);
    +          break;
    +        case LONG:
    +          Long.parseLong(value);
    +          break;
    +        case FLOAT:
    +          Float.parseFloat(value);
    +          break;
             default:
    -          return value;
    +          // do nothing
           }
         } catch (Exception e) {
    --- End diff --
    
    better to change to `NumberFormatException`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---