Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-620-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-620-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #620: [CARBONDATA-742] Added batch sort to...
Content-Type: text/plain
Message-Id: <20170314070802.DC91EDFE1E@git1-us-west.apache.org>
Date: Tue, 14 Mar 2017 07:08:02 +0000 (UTC)
archived-at: Tue, 14 Mar 2017 07:08:08 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/620#discussion_r105838661
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -1149,6 +1149,19 @@
     
       public static final String USE_KETTLE_DEFAULT = "false";
     
    +  /**
    +   * Sorts the data in batches and writes the batch data to store with index file.
    +   */
    +  public static final String LOAD_USE_BATCH_SORT = "carbon.load.use.batch.sort";
    +
    +  public static final String LOAD_USE_BATCH_SORT_DEFAULT = "true";
    --- End diff --
    
    Better to make it `false` as of now, and revisit it after checking the performance and loading and reading. 
    And please add comment mentioning something like "if fast loading is favored, set it to true. If fast query performance is favored, set it to false"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---