Return-Path: <issues-return-6109-archive-asf-public=cust-asf.ponee.io@carbondata.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B6F12200C32
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  9 Mar 2017 13:40:12 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id B5887160B67; Thu,  9 Mar 2017 12:40:12 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0AA94160B64
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  9 Mar 2017 13:40:11 +0100 (CET)
Received: (qmail 92331 invoked by uid 500); 9 Mar 2017 12:40:11 -0000
Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.incubator.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.incubator.apache.org>
List-Post: <mailto:issues@carbondata.incubator.apache.org>
List-Id: <issues.carbondata.incubator.apache.org>
Reply-To: dev@carbondata.incubator.apache.org
Delivered-To: mailing list issues@carbondata.incubator.apache.org
Received: (qmail 92322 invoked by uid 99); 9 Mar 2017 12:40:11 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 12:40:11 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C78EE1A7A61
	for <issues@carbondata.apache.org>; Thu,  9 Mar 2017 12:40:10 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.02
X-Spam-Level: 
X-Spam-Status: No, score=-4.02 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id vUv6ncsKKwOT for <issues@carbondata.apache.org>;
	Thu,  9 Mar 2017 12:40:10 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 253BF5FB5D
	for <issues@carbondata.incubator.apache.org>; Thu,  9 Mar 2017 12:40:08 +0000 (UTC)
Received: (qmail 92318 invoked by uid 99); 9 Mar 2017 12:40:08 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 12:40:08 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 43194DFF47; Thu,  9 Mar 2017 12:40:08 +0000 (UTC)
From: kumarvishal09 <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-631-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-631-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...
Content-Type: text/plain
Message-Id: <20170309124008.43194DFF47@git1-us-west.apache.org>
Date: Thu,  9 Mar 2017 12:40:08 +0000 (UTC)
archived-at: Thu, 09 Mar 2017 12:40:12 -0000

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/631#discussion_r105153484
  
    --- Diff: format/src/main/thrift/carbondata.thrift ---
    @@ -178,16 +178,27 @@ struct FileFooter{
         5: required list<BlockletIndex> blocklet_index_list;	// blocklet index of all blocklets in this file
         6: optional list<BlockletInfo> blocklet_info_list;	// Information about blocklets of all columns in this file
         7: optional list<BlockletInfo2> blocklet_info_list2;	// Information about blocklets of all columns in this file
    -    8: optional list<BlockletInfo3> blocklet_info_list3;	// Information about blocklets of all columns in this file
    -    9: optional dictionary.ColumnDictionaryChunk dictionary; // blocklet local dictionary
    +    8: optional dictionary.ColumnDictionaryChunk dictionary; // blocklet local dictionary
    +}
    +
    +/**
    +* Footer for indexed carbon file
    --- End diff --
    
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---