Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-631-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-631-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...
Content-Type: text/plain
Message-Id: <20170308232359.E710BF4B55@git1-us-west.apache.org>
Date: Wed,  8 Mar 2017 23:23:59 +0000 (UTC)
archived-at: Wed, 08 Mar 2017 23:24:19 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/631#discussion_r105051400
  
    --- Diff: format/src/main/thrift/carbondata_index.thrift ---
    @@ -41,6 +41,6 @@ struct IndexHeader{
     struct BlockIndex{
       1: required i64 num_rows; // Total number of rows in this file
       2: required string file_name; // Block file name
    -  3: required i64 offset; // Offset of block
    +  3: required i64 offset; // Offset of the footer
    --- End diff --
    
    Ok, don't change if it, backward compatibility is required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---