Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 46E28200C31 for ; Wed, 8 Mar 2017 14:48:17 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 42C44160B83; Wed, 8 Mar 2017 13:48:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A406160B75 for ; Wed, 8 Mar 2017 14:48:16 +0100 (CET) Received: (qmail 80641 invoked by uid 500); 8 Mar 2017 13:48:15 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 80632 invoked by uid 99); 8 Mar 2017 13:48:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2017 13:48:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 648B018056F for ; Wed, 8 Mar 2017 13:48:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id IltPTdOXQfI1 for ; Wed, 8 Mar 2017 13:48:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id BF59B5F1F4 for ; Wed, 8 Mar 2017 13:48:13 +0000 (UTC) Received: (qmail 80628 invoked by uid 99); 8 Mar 2017 13:48:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2017 13:48:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D26BDDFBD3; Wed, 8 Mar 2017 13:48:12 +0000 (UTC) From: jackylk To: issues@carbondata.incubator.apache.org Reply-To: issues@carbondata.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest... Content-Type: text/plain Message-Id: <20170308134812.D26BDDFBD3@git1-us-west.apache.org> Date: Wed, 8 Mar 2017 13:48:12 +0000 (UTC) archived-at: Wed, 08 Mar 2017 13:48:17 -0000 Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/634#discussion_r104919217 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -383,7 +383,7 @@ */ public static final String CARBON_TIMESTAMP_DEFAULT_FORMAT = "yyyy-MM-dd HH:mm:ss"; /** - * CARBON_TIMESTAMP_DEFAULT_FORMAT + * CARBON_TIMESTAMP_FORMAT,ONE PROPERTY FOR SPECIFYING DATATYPE IS TIMESTAMPE --- End diff -- suggest to change to: ``` Property for specifying timestamp format for TIMESTAMP data type column. e.g. yyyy-MM-dd HH:mm:ss, or using CARBON_TIMESTAMP_DEFAULT_FORMAT ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---