Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: ravipesala <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-627-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-627-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata issue #627: CARBONDATA-748
Content-Type: text/plain
Message-Id: <20170307094428.5F4FEDFC4A@git1-us-west.apache.org>
Date: Tue,  7 Mar 2017 09:44:28 +0000 (UTC)
archived-at: Tue, 07 Mar 2017 09:44:32 -0000

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/627
  
    @simafengyun Thanks for working on it.
    Range binary search is impressive. we can use same search in other places as well.
    But using this search in `setFilterdIndexToBitSet` is not always correct. Because here the data may not be sorted always, Only for the first column of dimensions is sorted naturally because of mdk order.
    And if the data is sorted explicitly(it means it has inverted index) then it goes to another method `setFilterdIndexToBitSetWithColumnIndex`.  So here we need extra checks to do binary search in the method `setFilterdIndexToBitSet` , that is like whether the column is naturally sorted or not.This information we may need get from store.  
    Please use this Range binary search in 'setFilterdIndexToBitSetWithColumnIndex' as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---