Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: sounakr <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-604-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-604-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #604: [CARBONDATA-691] After Compaction re...
Content-Type: text/plain
Message-Id: <20170303120812.BF30CDFE34@git1-us-west.apache.org>
Date: Fri,  3 Mar 2017 12:08:12 +0000 (UTC)
archived-at: Fri, 03 Mar 2017 12:08:17 -0000

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/604#discussion_r104141178
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala ---
    @@ -255,77 +256,75 @@ class CarbonMergerRDD[K, V](
     
         // mapping of the node and block list.
         var nodeBlockMapping: java.util.Map[String, java.util.List[Distributable]] = new
    -            java.util.HashMap[String, java.util.List[Distributable]]
    +        java.util.HashMap[String, java.util.List[Distributable]]
     
         var noOfBlocks = 0
         val taskInfoList = new java.util.ArrayList[Distributable]
         var carbonInputSplits = mutable.Seq[CarbonInputSplit]()
     
    -    var blocksOfLastSegment: List[TableBlockInfo] = null
    +    var splitsOfLastSegment: List[CarbonInputSplit] = null
    +    // map for keeping the relation of a task and its blocks.
    +    val taskIdMapping: java.util.Map[String, java.util.List[CarbonInputSplit]] = new
    +        java.util.HashMap[String, java.util.List[CarbonInputSplit]]
    +
     
         // for each valid segment.
         for (eachSeg <- carbonMergerMapping.validSegments) {
    -      // map for keeping the relation of a task and its blocks.
    -      val taskIdMapping: java.util.Map[String, java.util.List[TableBlockInfo]] = new
    -            java.util.HashMap[String, java.util.List[TableBlockInfo]]
     
           // map for keeping the relation of a task and its blocks.
           job.getConfiguration.set(CarbonInputFormat.INPUT_SEGMENT_NUMBERS, eachSeg)
     
    +      val updateDetails: UpdateVO = updateStatusManager.getInvalidTimestampRange(eachSeg)
    +      // val updateStatusManager = carbonLoadModel.getSegmentUpdateStatusManager
    --- End diff --
    
    Done. Removed the commented code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---