carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From watermen <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #659: Reuse the same SegmentProperties obj...
Date Thu, 16 Mar 2017 02:38:28 GMT
GitHub user watermen opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/659

    Reuse the same SegmentProperties objects to reduce the memory

    When I load carbondata 1000+ times with 35 nodes, I found SegmentProperties occupy 2.5+G(76K
* 35 * 1000) memory in driver. 
    ![carbonproperties](https://cloud.githubusercontent.com/assets/1400819/23979443/82d44320-0a34-11e7-9a5b-c4dcab4f9232.jpg)
    I don't have small files so I don't want to compact the segments. I analyzed the dump
file and found the values of SegmentProperties are the same, so I think we can reuse the SegmentProperties
object if possible.
    
    cc @jackylk @QiangCai 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/watermen/incubator-carbondata CARBONDATA-781

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #659
    
----
commit b82e26907bd6882399cd4084e7584379b10c934c
Author: Yadong Qi <qiyadong2010@gmail.com>
Date:   2017-03-15T09:41:42Z

    Reuse the same SegmentProperties to reduce the memory.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message