carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #696: [CARBONDATA-818] Make the file_name ...
Date Sun, 26 Mar 2017 05:58:25 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052532
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
    @@ -528,8 +528,7 @@ protected void fillBlockIndexInfoDetails(long numberOfRows, String
filePath,
         org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex blockletIndex =
             new org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex(btree, minmax);
         BlockIndexInfo blockIndexInfo =
    -        new BlockIndexInfo(numberOfRows, filePath.substring(0, filePath.lastIndexOf('.')),
    -            currentPosition, blockletIndex);
    +        new BlockIndexInfo(numberOfRows, filePath, currentPosition, blockletIndex);
    --- End diff --
    
    can you explain ,why do this change ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message