carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #659: [CARBONDATA-781] Store one SegmentPr...
Date Sat, 25 Mar 2017 11:07:32 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/659#discussion_r108033699
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndex.java
---
    @@ -16,30 +16,52 @@
      */
     package org.apache.carbondata.core.datastore.block;
     
    +import java.util.HashMap;
     import java.util.List;
    +import java.util.Map;
     
     import org.apache.carbondata.core.datastore.BTreeBuilderInfo;
     import org.apache.carbondata.core.datastore.BtreeBuilder;
     import org.apache.carbondata.core.datastore.impl.btree.BlockBTreeBuilder;
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier;
     import org.apache.carbondata.core.metadata.blocklet.DataFileFooter;
     
     /**
      * Class which is responsible for loading the b+ tree block. This class will
      * persist all the detail of a table segment
      */
     public class SegmentTaskIndex extends AbstractIndex {
    +  private static Map<SegmentKey, SegmentProperties> segmentPropertiesCached =
    --- End diff --
    
    why not use TableSegmentUniqueIdentifier?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message