carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #635: [CARBONDATA-782]support SORT_COLUMNS
Date Mon, 20 Mar 2017 07:32:37 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/635#discussion_r106844183
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java
---
    @@ -193,20 +193,42 @@ public void startSorting() throws CarbonSortKeyAndGroupByException
{
           toSort = new Object[entryCount][];
           System.arraycopy(recordHolderList, 0, toSort, 0, entryCount);
     
    -      if (parameters.isUseKettle()) {
    -        if (parameters.getNoDictionaryCount() > 0) {
    -          Arrays.sort(toSort, new RowComparator(parameters.getNoDictionaryDimnesionColumn(),
    -              parameters.getNoDictionaryCount()));
    +      if (parameters.getNumberOfSortColumns() == 0) {
    --- End diff --
    
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message