carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <>
Subject [GitHub] incubator-carbondata pull request #670: [CARBONDATA-792] Range Filter Optimi...
Date Sun, 19 Mar 2017 08:39:06 GMT
Github user gvramana commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/
    @@ -38,4 +38,17 @@ public Expression getRight() {
         return right;
    +  @Override public void setChildren(Expression oldExpr, Expression newExpr) {
    --- End diff --
    Change this function name to findAndSetChild.
    Also implement this method in **all** non leaf nodes, Like ListExpression

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message