carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #660: [CARBONDATA-784] Make configurable e...
Date Fri, 17 Mar 2017 06:39:28 GMT
Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/660#discussion_r106591401
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/MeasureFieldConverterImpl.java
---
    @@ -57,11 +61,18 @@ public void convert(CarbonRow row, BadRecordLogHolder logHolder)
         String value = row.getString(index);
         Object output;
         boolean isNull = CarbonCommonConstants.MEMBER_DEFAULT_VAL.equals(value);
    -    if (value == null || value.length() == 0 || isNull) {
    +    if (value == null || isNull) {
           logHolder.setReason(
               "The value " + " \"" + value + "\"" + " with column name " + measure.getColName()
                   + " and column data type " + dataType + " is not a valid " + dataType +
" type.");
           row.update(null, index);
    +    } else if (value.length() == 0) {
    --- End diff --
    
    both the condition could not be merged.
    when value is empty there will be two decision to be take
    1. empty is good 
    2. empty data is bad


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message