carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nareshpr <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #641: [CARBONDATA-767] Alter table support...
Date Wed, 15 Mar 2017 10:03:55 GMT
Github user nareshpr commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/641#discussion_r106125641
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
    @@ -304,38 +341,76 @@ class CarbonMetastore(conf: RuntimeConfig, val storePath: String)
{
         if (tableExists(tableName, Some(dbName))(sparkSession)) {
           sys.error(s"Table [$tableName] already exists under Database [$dbName]")
         }
    +    val schemaEvolutionEntry = new SchemaEvolutionEntry(tableInfo.getLastUpdatedTime)
         val schemaConverter = new ThriftWrapperSchemaConverterImpl
         val thriftTableInfo = schemaConverter
           .fromWrapperToExternalTableInfo(tableInfo, dbName, tableName)
    -    val schemaEvolutionEntry = new SchemaEvolutionEntry(tableInfo.getLastUpdatedTime)
         thriftTableInfo.getFact_table.getSchema_evolution.getSchema_evolution_history
           .add(schemaEvolutionEntry)
    +    val carbonTablePath = createSchemaThriftFile(tableInfo,
    +      thriftTableInfo,
    +      dbName,
    +      tableName)(sparkSession)
    +    updateSchemasUpdatedTime(touchSchemaFileSystemTime(dbName, tableName))
    +    LOGGER.info(s"Table $tableName for Database $dbName created successfully.")
    +    carbonTablePath
    +  }
     
    +  /**
    +   * This method will write the schema thrift file in carbon store and load table metadata
    +   *
    +   * @param tableInfo
    +   * @param thriftTableInfo
    +   * @param dbName
    +   * @param tableName
    +   * @param sparkSession
    +   * @return
    +   */
    +  private def createSchemaThriftFile(
    +      tableInfo: org.apache.carbondata.core.metadata.schema.table.TableInfo,
    +      thriftTableInfo: org.apache.carbondata.format.TableInfo,
    +      dbName: String, tableName: String)
    +    (sparkSession: SparkSession): String = {
         val carbonTableIdentifier = new CarbonTableIdentifier(dbName, tableName,
           tableInfo.getFactTable.getTableId)
         val carbonTablePath = CarbonStorePath.getCarbonTablePath(storePath, carbonTableIdentifier)
         val schemaFilePath = carbonTablePath.getSchemaFilePath
         val schemaMetadataPath = CarbonTablePath.getFolderContainingFile(schemaFilePath)
         tableInfo.setMetaDataFilepath(schemaMetadataPath)
         tableInfo.setStorePath(storePath)
    -    CarbonMetadata.getInstance().loadTableMetadata(tableInfo)
    -    val tableMeta = new TableMeta(carbonTableIdentifier, storePath,
    -      CarbonMetadata.getInstance().getCarbonTable(dbName + "_" + tableName))
    -
         val fileType = FileFactory.getFileType(schemaMetadataPath)
         if (!FileFactory.isFileExist(schemaMetadataPath, fileType)) {
           FileFactory.mkdirs(schemaMetadataPath, fileType)
         }
         val thriftWriter = new ThriftWriter(schemaFilePath, false)
    -    thriftWriter.open()
    +    thriftWriter.open(FileWriteOperation.OVERWRITE)
         thriftWriter.write(thriftTableInfo)
         thriftWriter.close()
    +    removeTableFromMetadata(dbName, tableName)
    --- End diff --
    
    As per old code, when new table is created, table info is added into CarbonMetastore and
modified.mdt file is timestamp is updated to refresh in other sessions. Those changes are
extracted to a new method and used in CreateTable and AlterTable flow, updating mdt file code
is missing, which i added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message