carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nareshpr <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #641: [CARBONDATA-767] Alter table support...
Date Wed, 15 Mar 2017 08:58:17 GMT
Github user nareshpr commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/641#discussion_r106112761
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataTypeConverterUtil.scala
---
    @@ -77,4 +77,40 @@ object DataTypeConverterUtil {
           case DataType.STRUCT => "struct"
         }
       }
    +
    +  /**
    +   * convert from wrapper to external data type
    +   *
    +   * @param dataType
    +   * @return
    +   */
    +  def convertToThriftDataType(dataType: String): org.apache.carbondata.format.DataType
= {
    --- End diff --
    
    There is no direct string to thrift datatype conversion. When creating table, we first
convert string to Wrapper datatype and from wrapper datatype, we convert into thrift datatype.
This method is required for alter table, as we r directly converting string to thrift type
in alter table change datatype


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message