carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #641: [CARBONDATA-767] Alter table support...
Date Tue, 14 Mar 2017 17:31:04 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/641#discussion_r105969726
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -966,20 +974,22 @@ public static void clearBlockCache(List<AbstractIndex> dataBlocks)
{
         List<Boolean> isDictionaryDimensions = new ArrayList<Boolean>();
         Set<Integer> processedColumnGroup = new HashSet<Integer>();
         for (CarbonDimension carbonDimension : tableDimensionList) {
    -      List<CarbonDimension> childs = carbonDimension.getListOfChildDimensions();
    -      //assuming complex dimensions will always be atlast
    -      if (null != childs && childs.size() > 0) {
    -        break;
    -      }
    -      if (carbonDimension.isColumnar() && hasEncoding(carbonDimension.getEncoder(),
    -          Encoding.DICTIONARY)) {
    -        isDictionaryDimensions.add(true);
    -      } else if (!carbonDimension.isColumnar()) {
    -        if (processedColumnGroup.add(carbonDimension.columnGroupId())) {
    +      if (!carbonDimension.isInvisible()) {
    --- End diff --
    
    The list which is being created, should have two getters. one to get With invisible and
other to get without invisible. Use required function accordingly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message