carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #622: [CARBONDATA-744] The property "spark...
Date Tue, 14 Mar 2017 11:18:52 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r105881019
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
    @@ -116,8 +117,9 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution",
false)) {
    +      } else if (java.lang.Boolean.parseBoolean(CarbonProperties.getInstance()
    +        .getProperty(CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION,
    --- End diff --
    
    Please simplify as follows
    ```
    CarbonProperties.getInstance()
            .getProperty(CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION,
              CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION_DEFAULT).toBoolean
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message