carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #651: [CARBONDATA-766] Sized based blockle...
Date Mon, 13 Mar 2017 13:12:04 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/651#discussion_r105655639
  
    --- Diff: format/src/main/thrift/carbondata.thrift ---
    @@ -136,7 +136,7 @@ struct DataChunk2{
     * Represents a chunk of data. The chunk can be a single column stored in Column Major
format or a group of columns stored in Row Major Format.
     **/
     struct DataChunk3{
    -    1: required list<DataChunk2> data_chunk_list; // list of data chunk
    +    1: required list<binary> data_chunk_list; // list of data chunk
    --- End diff --
    
    I guess it is better to keep `DataChunk2` to get clear dependency and understanding. Otherwise
user cannot figure out what is inside `list<binary>`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message