carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #649: [CARBONDATA-748] put 'if' clause out...
Date Sun, 12 Mar 2017 05:52:50 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/649#discussion_r105549626
  
    --- Diff: core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
    @@ -96,13 +93,39 @@ private BitSet setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
       @Test
       public void testPerformance() {
     
    -    long oldTime = 0;
    -    long newTime = 0;
    -    long start;
         int dataCnt = 120000;
    +    int queryCnt = 5;
    +    int repeatCnt = 200;
    +    
         int filterCnt = 800;
    +    comparePerformance(dataCnt, filterCnt, queryCnt, repeatCnt);
    +    
    +    filterCnt = 100;
    +    comparePerformance(dataCnt, filterCnt, queryCnt, repeatCnt);
    +
    +  }
    +  
    +  @Test
    +  public void testBoundary() {
    --- End diff --
    
    Can you explain why add testBoundary() ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message