carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...
Date Sat, 11 Mar 2017 02:53:49 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/640#discussion_r105523770
  
    --- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala
---
    @@ -44,7 +44,7 @@ object CarbonExample {
         // Currently there are two data loading flows in CarbonData, one uses Kettle as ETL
tool
         // in each node to do data loading, another uses a multi-thread framework without
Kettle (See
         // AbstractDataLoadProcessorStep)
    -    // Load data with Kettle
    +    // Load data without Kettle(by Default,use_kettle='false')
    --- End diff --
    
    Yes, your PR is valid.  I suggest : you can remove all kettle related code, make the example
more clear and simple :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message