carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...
Date Wed, 08 Mar 2017 23:23:59 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/631#discussion_r105051400
  
    --- Diff: format/src/main/thrift/carbondata_index.thrift ---
    @@ -41,6 +41,6 @@ struct IndexHeader{
     struct BlockIndex{
       1: required i64 num_rows; // Total number of rows in this file
       2: required string file_name; // Block file name
    -  3: required i64 offset; // Offset of block
    +  3: required i64 offset; // Offset of the footer
    --- End diff --
    
    Ok, don't change if it, backward compatibility is required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message