carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...
Date Wed, 08 Mar 2017 13:48:51 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/634#discussion_r104919325
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -392,7 +392,7 @@
        */
       public static final String CARBON_DATE_DEFAULT_FORMAT = "yyyy-MM-dd";
       /**
    -   * CARBON_DATE_DEFAULT_FORMAT
    +   * CARBON_DATE_FORMAT,ONE PROPERTY FOR SPECIFYING DATATYPE IS DATE
    --- End diff --
    
    suggest to change to:
    ```
    Property for specifying date format for DATE data type column. 
    e.g. yyyy-MM-dd, or using CARBON_DATE_DEFAULT_FORMAT
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message