carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #622: [CARBONDATA-744] The property "spark...
Date Mon, 06 Mar 2017 22:54:21 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/622#discussion_r104545841
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
    @@ -116,8 +116,8 @@ class CarbonScanRDD(
               i += 1
               result.add(partition)
             }
    -      } else if (sparkContext.getConf.contains("spark.carbon.custom.distribution") &&
    -                 sparkContext.getConf.getBoolean("spark.carbon.custom.distribution",
false)) {
    +      } else if (java.lang.Boolean
    +        .parseBoolean(CarbonProperties.getInstance().getProperty("carbon.custom.distribution")))
{
    --- End diff --
    
    The PR's title mentions that the property is "spark.carbon.custom.distribution", but here
you change the property name to "carbon.custom.distribution", why ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message